Prevent errors when using ViewportTexture #75751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
approved these changes
May 2, 2023
mhilbrunner
approved these changes
May 5, 2023
akien-mga
reviewed
May 8, 2023
Comment on lines
+2785
to
+2791
| bool Node::is_ready() const { | ||
| return !data.ready_first; | ||
| } |
There was a problem hiding this comment.
Should we expose this to the bindings?
There was a problem hiding this comment.
It needs a different name, because RichTextLabel already has is_ready() 🙃
There was a problem hiding this comment.
Ouch... The RTL one should be named is_done_processing or similar... but that would break compat.
There was a problem hiding this comment.
Ok exposed it as is_node_ready().
akien-mga
approved these changes
May 8, 2023
KoBeWi
force-pushed
the
eradicate_ViewportTexture_errors_entirely_and_surely
branch
from
40d8c9c
to
1b9802f
Compare
|
Thanks! |
|
I note this has also fixed an (unticketed, to my knowledge) issue with a |
|
Cherry-picked for 4.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup_local_to_scene()is called right when the texture is initializing. It often fails on the first attempt, because the scene is not fully initialized and the assigned node path is still not valid. This PR ensures that ViewportTexture will only try to setup when the scene is prepared. Also there is no way to reasonably expect the texture to immediately hold correct data (size etc.), so I silenced the errors until the texture is initialized. It was already working correctly with the errors, so this PR just changes it to "intended behavior" and removes error spam.Fixes #75740 and probably similar issues.
Ah I also had to add
is_ready()method to Node, to reliably check if the node is ready. Maybe it could be exposed to scripting, because it's useful sometimes (althoughis_inside_tree()is enough in most cases).